Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test time reporting under the threshold #101

Closed
joravasal opened this issue Nov 14, 2018 · 3 comments
Closed

Test time reporting under the threshold #101

joravasal opened this issue Nov 14, 2018 · 3 comments

Comments

@joravasal
Copy link

Hi,

Just a small idea to expand on the report of time the tests take to execute. It maybe could be possible to add another option other than slowThreshold, something along the lines of timeReportThreshold, to show the time of the tests from that time. Maybe in a different color (green? same color of the rest of the theme?), and use the slowThreshold just to be able to set a limit to what is acceptable.

Definitely not the most urgent or important change, but it would help in my case where I am trying to improve the time tests take, and I need to set the slowThreshold very low to see the times of most tests, which makes many go red and is more difficult to filter them at a glance.

Thanks for the effort on the plugin, it is very helpful.

@radarsh
Copy link
Owner

radarsh commented Nov 16, 2018

Hi, thanks for this. Have you explored the test reports Gradle already produces? It already has the kind of info you are looking for. For instance, this is what I get when I run the plugin's functional tests and look at the reports under build/reports/tests directory.

image

It won't filter it by any threshold but if your goal is to identify slow tests and make them fast, the test reports are a great starting point.

@joravasal
Copy link
Author

Hi, thanks for the prompt answer.

Yes, we are using it currently, but as I added this logging tool I thought it could be a nice addition. Again, it is really not a big deal, just something I thought could improve it :)

Feel free to close this ticket if you feel it doesn't add much to the logs.

@radarsh
Copy link
Owner

radarsh commented Nov 20, 2018

While I do see the value in your requirement, in the spirit of keeping the plugin logic simple and to avoid having conflicting configuration options I'm going to close this issue for now. We can accomplish what you're asking currently by setting slowThreshold to 0. Example:

image

@radarsh radarsh closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants