adds filter for showing only slow tests #207

grimmjo · 2021-05-13T14:15:20Z

closes #158

…lish Upgrade plugin publish plugin

grimmjo · 2021-12-08T19:31:56Z

any news on this?
What needs to be done to get this PR merged?

Kind regards

radarsh · 2021-12-10T12:29:59Z

Hi @grimmjo, only feedback I have is to rename showSlow to showOnlySlow to be very clear. Please make these changes and it can then be merged. Thank you for the PR.

Oh and while you're there, could you also document this new property in the README? Thanks.

closes radarsh#158

grimmjo · 2021-12-10T18:04:46Z

Hi @radarsh,
renaming is done and I also added the parameter to the README. I think we should be ready to merge 😃
When do you plan to release the next version?

src/main/groovy/com/adarshr/gradle/testlogger/TestLoggerExtensionProperties.groovy

radarsh · 2021-12-16T10:58:27Z

Hi @grimmjo there seems to be a problem. I'm running the tests with showOnlySlow=true and yet it's showing all tests, slow and fast.

➜  gradle-test-logger-plugin git:(slowFilter) ./gradlew clean test -Dtestlogger.showOnlySlow=true -Dtestlogger.slowThreshold=100

> Task :test

  com.adarshr.gradle.testlogger.renderer.AnsiTextRendererSpec

    render #input

      ✔ render [red]text (130ms)
      ✔ render [bright-red]text
      ✔ render [foo]text
      ✔ render [red,foo]text
      ✔ render [yellow]text
      ✔ render [bright-yellow]text
      ✔ render [green]text
      ✔ render [bright-green]text
      ✔ render [bold][red]text[/]
      ✔ render [bold,red]text[/]
      ✔ render [erase-all,bold,red]text[/]
      ✔ render [erase-ahead,bold,red]text[/]
      ✔ render [erase-back,bold,red]text[/]
      ✔ render [cursor-up-line]text[/]
      ✔ render [red][red][/]
      ✔ render [bold]text[bold-off]
      ✔ render [default]text
      ✔ render [grey]text
      ✔ render [cyan]text
      ✔ render [bright-cyan]text
      ✔ render [blue]text
      ✔ render [bright-blue]text
      ✔ render [magenta]text
      ✔ render [bright-magenta]text

  com.adarshr.gradle.testlogger.logger.OutputCollectorSpec

    ✔ output collector collects output by descriptor ID and removes them accordingly (912ms)

  com.adarshr.gradle.testlogger.logger.TestLoggerWrapperSpec

    ✔ wrapper delegates to sequential test logger if parallel theme is not applied (55ms)
    ✔ wrapper delegates to parallel test logger if parallel theme is applied

  com.adarshr.gradle.testlogger.logger.ConsoleLoggerSpec

    ✔ log
    ✔ does not log empty strings
    ✔ log new line
    ✔ configurable log level

radarsh · 2021-12-16T11:07:40Z

README.md

 }
 ```

-By default all the above three flags are turned on. If you have chosen to display standard streams by setting
+By default all the above four flags are turned on. If you have chosen to display standard streams by setting


showOnlySlow is will be off by default. So this goes back to being

By default the flags showPassed, showSkipped and showFailed are turned on while showOnlySlow will be off.

done ;) just inserted your quote.

radarsh · 2021-12-16T11:09:08Z

src/main/groovy/com/adarshr/gradle/testlogger/TestResultWrapper.groovy

@@ -21,7 +21,8 @@ class TestResultWrapper {
    boolean isLoggable() {
        testLoggerExtension.showPassed && testResult.successfulTestCount ||
            testLoggerExtension.showSkipped && (testResult.resultType == SKIPPED || testResult.skippedTestCount) ||
-            testLoggerExtension.showFailed && testResult.failedTestCount
+            testLoggerExtension.showFailed && testResult.failedTestCount ||
+            testLoggerExtension.showOnlySlow && (isTooSlow() || isMediumSlow())


There is something wrong with this expression.

I was able to get it to work by changing the method body to be as below. If you can do it in a more readable manner, please do so.

if (testLoggerExtension.showOnlySlow && (!isTooSlow() || !isMediumSlow())) { return false } testLoggerExtension.showPassed && testResult.successfulTestCount || testLoggerExtension.showSkipped && (testResult.resultType == SKIPPED || testResult.skippedTestCount) || testLoggerExtension.showFailed && testResult.failedTestCount

Refactored this method a little bit to make it more readable

radarsh · 2021-12-16T11:36:20Z

My understanding of this flag is:

Given showOnlySlow=true and slowThreshold=5000
And I have a test "test-1" that takes "10000" ms to run
And I have a test "test-2" that takes "3000" ms to run
When I run the tests
Then I should see "test-1" printed

and

Given showOnlySlow=false and slowThreshold=5000
And I have a test "test-1" that takes "10000" ms to run
And I have a test "test-2" that takes "3000" ms to run
When I run the tests
Then I should see "test-1" and "test-2" printed

radarsh · 2021-12-16T11:49:35Z

src/main/groovy/com/adarshr/gradle/testlogger/TestLoggerExtension.groovy

@@ -227,6 +229,15 @@ class TestLoggerExtension extends TestLoggerExtensionProperties {
            .getOrElse(false)
    }

+    Boolean getshowOnlySlow() {


Typo in the method name :) This is why the command line argument wasn't working. It should be getShowOnlySlow (capitalised).

My mistake. Done ;)

radarsh · 2021-12-16T11:54:16Z

src/test/groovy/com/adarshr/gradle/testlogger/TestResultWrapperSpec.groovy

@@ -127,6 +127,29 @@ class TestResultWrapperSpec extends Specification {
            10001         | false
    }

+    @Unroll
+    def "loggable returns false if showOnlySlow is turned #showOnlySlow"() {


The tests will need fixing too

grimmjo · 2021-12-17T08:09:04Z

My understanding of the flag is a little bit different as you may see in the isLoggable method.
First we need to check if either one of the flags showPassed, showSkipped or showFailed should be applied.
The showOnlySlow then filters the results from above.

What we should think about is, that we only should filter the passed test as the consumer may wants to see always the skipped and failed tests.

radarsh · 2021-12-17T16:43:23Z

You make a very good point here.

What we should think about is, that we only should filter the passed test as the consumer may wants to see always the skipped and failed tests.

We shouldn't hide failing tests because they failed fast :) But your PR seems to be already doing this.

grimmjo · 2022-01-03T08:34:54Z

Hi @radarsh 😃

belated happy new year ;) Do you have any plans on merging this pr and releasing a new version?

radarsh · 2022-01-05T12:59:02Z

@grimmjo Happy New Year. Yeah, let me get this done this week.

radarsh added 3 commits June 30, 2020 12:15

Merge pull request radarsh#155 from radarsh/hotfix/upgrade-plugin-pub…

85f76c7

…lish Upgrade plugin publish plugin

Merge branch 'release/2.1.1'

7330002

Merge branch 'release/3.0.0'

2f078e5

grimmjo force-pushed the slowFilter branch from 30b412d to 59f360a Compare May 13, 2021 14:16

grimmjo changed the title ~~adds filter for only showing slow tests~~ adds filter for showing only slow tests May 13, 2021

Merge branch 'release/3.1.0'

a6aca88

grimmjo added 2 commits December 10, 2021 18:45

adds filter for only showing slow tests

48552b4

closes radarsh#158

rename showSlow to showOnlySlow and add it to the README

5d337d5

grimmjo force-pushed the slowFilter branch from 59f360a to 5d337d5 Compare December 10, 2021 18:01

radarsh reviewed Dec 11, 2021

View reviewed changes

src/main/groovy/com/adarshr/gradle/testlogger/TestLoggerExtensionProperties.groovy Outdated Show resolved Hide resolved

set default of showOnlySlow to false

3da76a4

grimmjo force-pushed the slowFilter branch from 8a3a312 to 3da76a4 Compare December 11, 2021 21:45

grimmjo requested a review from radarsh December 13, 2021 16:01

radarsh requested changes Dec 16, 2021

View reviewed changes

radarsh reviewed Dec 16, 2021

View reviewed changes

code review changes

e23f622

grimmjo requested a review from radarsh December 17, 2021 08:13

radarsh approved these changes Dec 17, 2021

View reviewed changes

radarsh merged commit af38e98 into radarsh:develop Jan 11, 2022

prasrvenkat mentioned this pull request Feb 20, 2022

Possible for a new minor release? #259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds filter for showing only slow tests #207

adds filter for showing only slow tests #207

grimmjo commented May 13, 2021 •

edited

grimmjo commented Dec 8, 2021

radarsh commented Dec 10, 2021 •

edited

grimmjo commented Dec 10, 2021

radarsh commented Dec 16, 2021

radarsh Dec 16, 2021

grimmjo Dec 17, 2021

radarsh Dec 16, 2021

radarsh Dec 16, 2021 •

edited

grimmjo Dec 17, 2021

radarsh commented Dec 16, 2021

radarsh Dec 16, 2021

grimmjo Dec 17, 2021

radarsh Dec 16, 2021

grimmjo Dec 17, 2021

grimmjo commented Dec 17, 2021

radarsh commented Dec 17, 2021

grimmjo commented Jan 3, 2022

radarsh commented Jan 5, 2022

adds filter for showing only slow tests #207

adds filter for showing only slow tests #207

Conversation

grimmjo commented May 13, 2021 • edited

grimmjo commented Dec 8, 2021

radarsh commented Dec 10, 2021 • edited

grimmjo commented Dec 10, 2021

radarsh commented Dec 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radarsh Dec 16, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radarsh commented Dec 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grimmjo commented Dec 17, 2021

radarsh commented Dec 17, 2021

grimmjo commented Jan 3, 2022

radarsh commented Jan 5, 2022

grimmjo commented May 13, 2021 •

edited

radarsh commented Dec 10, 2021 •

edited

radarsh Dec 16, 2021 •

edited