Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of testLogger.showStandardStreams can lead to confusion #86

Closed
ivoanjo opened this issue Sep 23, 2018 · 3 comments
Closed

Use of testLogger.showStandardStreams can lead to confusion #86

ivoanjo opened this issue Sep 23, 2018 · 3 comments
Assignees
Milestone

Comments

@ivoanjo
Copy link

ivoanjo commented Sep 23, 2018

Hello there,

Thank you very much for this nice plugin! We really need user-friendly tools like yours in the Java community!

I was looking for a way to enable printing of stdout/stderr of my tests, and everywhere I googled I was pointed at gradle Test task's testLogging.showStandardStreams option.

But because I use gradle-test-logger-plugin, this wasn't working. After some time it dawned on me that the issue may come from the plugin, and I was able to confirm this and then go into the documentation and see that with this plugin, one should actually use testLogger.showStandardStreams instead.

Since this is a bit confusing, I would like to suggest that support for reading from testLogging.showStandardStreams also be added. I believe that would a lot more predictable for people with existing test configurations, and hopefully no other users would lose a few minutes banging their heads against this small issue.

Thanks for your time! 🙏

@radarsh
Copy link
Owner

radarsh commented Sep 24, 2018

This is a great idea, thanks for the feedback.

I'll see if I can derive any other values based on the configuration of testLogging.

@radarsh radarsh self-assigned this Sep 24, 2018
@radarsh
Copy link
Owner

radarsh commented Oct 18, 2018

This is dependent on #90 as testLogging.showStandardStreams can be virtually configured for any task of type Test and it wouldn't be right to change the global testlogger configuration based on the value of any individual test task configuration.

@ivoanjo
Copy link
Author

ivoanjo commented Oct 29, 2018

Thank you for the awesome fix! 👍

@radarsh radarsh added this to the 1.6.0 milestone Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants