Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple usability suggestions #88

Closed
cjstehno opened this issue Oct 9, 2018 · 2 comments
Closed

A couple usability suggestions #88

cjstehno opened this issue Oct 9, 2018 · 2 comments

Comments

@cjstehno
Copy link

cjstehno commented Oct 9, 2018

I like the plugin but I ran into a couple things that would be nice to have (especially during first-time use):

  1. Small but took a minute to find - I am used to camelCase with Java and Groovy names, so I started out with testLogger eventually realized the L is not capitalized. Maybe make both valid or just point out the difference in the documentation.
  2. My projects use parallel tests which caused the theme to fail. It appears to know that I am using parallel testing - if this is the case, could you not switch to the parallel version of the same theme and provide a warning log that this change was made.

These are just suggestions - feel free to close this issue if they are not something you want to pursue.

@radarsh
Copy link
Owner

radarsh commented Oct 17, 2018

Thanks for the feedback. Regarding the first point, I chose all lowercase inspired by Gradle's own convention for some DSLs (subprojects, buildscript etc). But in retrospect testlogger does look a bit dated. I will think about supporting both testlogger and testLogger.

Your second point about switching to a corresponding parallel theme is interesting. Let me consider that too.

@radarsh
Copy link
Owner

radarsh commented Oct 2, 2019

I would like the plugin's behaviour to be predictable. Therefore, I am going to abandon the idea of automatically switching themes based on Gradle settings, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants