Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqfile gone #6

Closed
dpocock opened this issue Nov 22, 2015 · 3 comments
Closed

seqfile gone #6

dpocock opened this issue Nov 22, 2015 · 3 comments

Comments

@dpocock
Copy link
Contributor

dpocock commented Nov 22, 2015

I notice seqfile is gone from the config.

I remember the file being created at some point in the past but I don't recall what changed.

I looked through the repository and found commit 3c3caa0 which introduces an rc_get_id() method, using random() to generate the sequence number and stripping out all code for the seqfile itself.

Maybe this is something else that should be mentioned in a file about upgrading from FreeRADIUS-client and its predecessors. People can delete the seqfile if it exists on their system and remove those lines from their config.

@nmav
Copy link
Contributor

nmav commented Nov 23, 2015

This is before my time in freeradius-client and I've never used seqfile. Do yo have some suggested text for that? I think it can be part of the readme file in github.

@dpocock
Copy link
Contributor Author

dpocock commented Nov 24, 2015

Looking here: ftp://ftp.freeradius.org/pub/freeradius/old/

it appears that 1.1.6 was released 2007-04-11

The seqfile support was removed by commit 3c3caa0 on 2010-02-04 so this change was only released in FreeRADIUS-client 1.1.7 and radcli 1.2.0.

It is mentioned briefly in doc/ChangeLog, maybe you should combine doc/ChangeLog and NEWS into one file to avoid confusion? I've submitted pull request #7 expanding details about it in doc/ChangeLog

@nmav
Copy link
Contributor

nmav commented Nov 26, 2015

Should be addressed by your PR.

@nmav nmav closed this as completed Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants