Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: make blurradius animatable #9

Open
getaaron opened this issue Nov 19, 2013 · 8 comments
Open

Feature Request: make blurradius animatable #9

getaaron opened this issue Nov 19, 2013 · 8 comments
Milestone

Comments

@getaaron
Copy link

I think this would require a significant rewrite. This is outside my area of expertise, so I'm not sure what the feasibility is. I think we'd have to extend CALayer instead of UIView (see http://stackoverflow.com/questions/2395382/animating-a-custom-property-of-calayer-subclass).

@evadne
Copy link
Owner

evadne commented Nov 20, 2013

I don’t think this will require a heavy rewrite. Note that what CAAnimation
all does is to solve value at time. It is IMHO possible to — duh, exactly
what your link mentioned. We can use a custom subclass and stash blur
radius (kernel size) on it. I am not sure if it will be fast enough though.

On Nov 20, 2013, at 6:09 AM, Aaron Brager notifications@github.com wrote:

I think this would require a significant rewrite. This is outside my area
of expertise, so I'm not sure what the feasibility is. I think we'd have to
extend CALayer instead of UIView (see
http://stackoverflow.com/questions/2395382/animating-a-custom-property-of-calayer-subclass
).


Reply to this email directly or view it on
GitHubhttps://github.com//issues/9
.

@ghost
Copy link

ghost commented Nov 20, 2013

What @evadne said, and we'd also have to override +layerClass on the UIView to return the class of the new CALayer subclass.

I'd like to avoid changing the existing interface, since nobody wants to update their project submodules and pods and — SURPRISE! — experience the fun and excitement of seeing their build break.

@ghost
Copy link

ghost commented Dec 12, 2013

For what it's worth, cross fading between blurred images does a really good job of simulating an animated blur radius. I'm normally pretty particular about how animations look, but even I had a hard time telling that the blur radius wasn't animating.

@ArtFeel
Copy link

ArtFeel commented Dec 12, 2013

I agree with @LucasTizma, in my project I'm simply fadeIn view.alpha, and it looks very good.

@getaaron
Copy link
Author

The alpha fade looks good on some views, but it doesn't work as well on high contrast / sparsely populated views.

@ghost
Copy link

ghost commented Jan 18, 2014

To add my two cents, I do think that migrating to a CALayer subclass with a UIView subclass for an interface is the best long term solution. That should yield a few more benefits, like allowing us to keep the entire blur effect in lockstep with animation.

It's not quite as high on the list of priorities right now, but that would probably be our next major release, 2.0 or something like that.

As for blurradius, we do enough pre-caching that making blurradius animatable will probably be really, really slow. But I think it's still worth trying.

If it's too slow, there will just have to be another barrier in the interface to make sure that $DEVELOPER really, really wants to do this.

Kind of like trying to die in a LucasArts game.

@getaaron
Copy link
Author

Yeah. Maybe the animated blurRadius Is only enabled if you win a round of Insult Swordfighting.

@whitneyland
Copy link

Another thing that would make this nice is that the built in iOS8 UIBlurEffect still does not have an animatable radius. Search continues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants