A recent change to ivy causes ivy-prescient to break counsel-rg

[drrlvn]

Using a recent version of ivy/counsel (20181124.2152), when ivy-prescient is enabled then counsel-rg never finds any results and always shows "No matches found". Disabling ivy-precient-mode fixes this.

I'm sorry I can't provide many details but I don't know exactly what change caused this and what exactly is broken.

[raxod502]

Yep, I can confirm that this is a bug somewhere. It was introduced by some change between abo-abo/swiper@bd980d8 and abo-abo/swiper@7b6765b. I won't have time to look at this soon, but I put it on my to-do list.

[wedens]

I've stumbled upon this bug too: abo-abo/swiper#1823 (comment)

Default changed to ivy--regex-plus from ivy--regex caused some incompatibility.

[Jasu]

Prescient works for me with prescient-filter-method set to regexp or literal. For regexp, if I type test., it matches as a literal ., i.e. not arbitrary characters. fuzzy seems to give weird results, and initialism and literal+initialism don't give any result at all.

My guess is that this commit made Ivy execute commands passed as lists without Bash, so the arguments should no longer be shell-escaped if they are passed as a list.

[raxod502]

In fact, the culprit is commit abo-abo/swiper@a041fd6 which was introduced to fix abo-abo/swiper#1801. I am looking into the problem.

[raxod502]

This is a bug in Counsel. It should be fixed as soon as abo-abo/swiper#1863 is merged.

[drrlvn]

Thank you very much for the investigation and upstream fixes!

[raxod502]

Should be fixed now that abo-abo/swiper#1863 is merged.