This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Add back the play log while keeping the forward and backward button #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a part of the issue here may be copyright concerns. When this app first got really public a lot of people said the developer was going to get in trouble for using the Google logo without copyright privileges. I could be wrong though. |
|
@zfy0701 I put this behind a preference, off by default since I consider it better without the logo. I appreciate the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to create this pull request because the removing the the google log doesn't make UI feel right. e.g. the search bar is not too close to the left. So I want to keep the logo while keeping the button. Though now it is still not perfect, I think it looks better than without the logo.