Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Thumbs up/down images are incorrect #56

Closed
kbhomes opened this issue Mar 5, 2014 · 0 comments
Closed

Thumbs up/down images are incorrect #56

kbhomes opened this issue Mar 5, 2014 · 0 comments
Labels
Milestone

Comments

@kbhomes
Copy link
Member

kbhomes commented Mar 5, 2014

On a very related note, maybe figure out some way to make these styles more robust. Seems that Google's spritesheet generating mechanism regularly creates different spritesheets that relocate the thumbs up and down icons. Therefore we should try to figure out a way to move the thumbs up and down in each .song-row without changing the background-position.

Alternatively, we can have the app download and use the latest version of the stylesheet every time the application runs so that simple style changes can be pushed to everybody without requiring an update of the app every time. Alternatively, we could include a built-in style manager (tangentially, user provided styles, perhaps...?) that downloads the latest style, but that could be confusing as it creates two points of update for the user, the stylesheets and the app itself.

@kbhomes kbhomes added this to the v1.1.0 milestone Mar 5, 2014
@kbhomes kbhomes added the bug label Mar 5, 2014
@kbhomes kbhomes closed this as completed in 3f8708a Mar 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant