Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Ratings aren't appearing in playlist #59

Closed
dodgepong opened this issue Mar 7, 2014 · 1 comment
Closed

Ratings aren't appearing in playlist #59

dodgepong opened this issue Mar 7, 2014 · 1 comment

Comments

@dodgepong
Copy link

The "Rating" column isn't showing a rating on songs that I have rated.

For example, all the songs in this list are songs that I have rated up in the normal browser-based Google Music, but none of them show any rating at all. However, the correct rating appears in the bottom right corner of the screen when playing the song:

http://i.imgur.com/hhiW8Fv.png

@kbhomes
Copy link
Member

kbhomes commented Mar 7, 2014

Ah, yeah, this is an issue that I've needed to overhaul, and I think I've figured out a good way to solve it. The problem is that without any changes, the thumbs up and down are cut off since the size of the song row is smaller than usual, so to fix that I'd change the background-position of the images to center them in the row. However, Google's deployment process changes the positions of the images in spritesheet every time so the positions of the thumbs up and down get updated frequently.

I've fixed this in a recent commit by checking the background positions of the thumbs up and down in JS first and then updating them. This way the thumbs up and down images should be normal every time.

Anywho, bottom line is that this is fixed now and should be fixed for a good while after the next release, 1.1.0, this weekend.

@kbhomes kbhomes closed this as completed Mar 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants