This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Use semi-private API so notifications act like iTunes. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! I merged it in, replacing the conditional with a user preference. I'm not worried about the use of the private API, since Mac App Store is not on the roadmap currently. I have this hiding behind a preference to enable "iTunes style notifications", since I personally preferred the notifications with the larger album art and larger application icon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% confident in wanting to get this merged, but I figured it was worth a shot and would be better than me re-patching and re-compiling after every update. 馃榿
This PR enables (conditional!) use of the user notification SPI that iTunes does, achieving identical notifications with improved album art and information density.