Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Merino don't support Coroutine #36

Closed
smbss1 opened this issue Aug 26, 2019 · 3 comments
Closed

Merino don't support Coroutine #36

smbss1 opened this issue Aug 26, 2019 · 3 comments

Comments

@smbss1
Copy link

smbss1 commented Aug 26, 2019

I created my yarn file and inside I write a command but the command doesn't call the Ienumerator method who I assigned

@radiatoryang
Copy link
Owner

radiatoryang commented Aug 27, 2019

so this is also part of a bigger UX design problem with how Merino should handle Yarn Commands...

  • if Merino executes Yarn Commands during edit mode, it would likely edit the current scene in harmful ways or just flat-out crash when that command isn't intended to execute outside of play mode
  • but Yarn Command coroutines can be very important for timing dialogue, delays, setting variables or game state, etc.
  • some users might engineer their game to support running in-game Yarn Commands during edit time

some possible design solutions:

  • checkbox on PlaytestWindow ("Execute Commands?")
  • user configurable blacklist / whitelist of Yarn Commands to execute and/or ignore

most of the work will involve grabbing the code from the Yarn Spinner DialogueRunner (https://github.com/thesecretlab/YarnSpinner/blob/master/Unity/Assets/YarnSpinner/Code/DialogueRunner.cs) and porting it to Merino's internal dialogue runner (https://github.com/radiatoryang/merino/blob/master/Assets/Merino/Editor/Scripts/Playtest/MerinoPlaytestWindow.cs)... especially the DispatchCommand functionality

PRs are welcome, but if not, I'll get around to this in a month or so

@smbss1
Copy link
Author

smbss1 commented Aug 27, 2019

I found the error, it's because on Import Merino, it's overwrite all the Yarn file and put a old Yarn version so solve this just import Merino first then Import Yarn and it should work.

Thank you @radiatoryang for your answer but my problem was really easy to solve it.

If there is someone who has a problem like mine but is not solved, try to do what Radiatoryang says.

@smbss1 smbss1 closed this as completed Aug 27, 2019
@radiatoryang
Copy link
Owner

oh, nice, lol

next time you can also download and import the Merino "minimal" package, if you want to use a different version of Yarn Spinner in the future... that way, it won't replace your newer version of Yarn Spinner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants