unused view - AnalysisView?

[devoncarew]

Is the AnalysisView used anymore? It's in lib/views/analysis_view.coffee. Is see some code referencing it, but suspect that it is left over from previous refactorings? If you try and call the toggle analysis view command you get an exception.

[radicaled]

AnalysisView is defunct. I think most items in lib/views are.

AnalysisView was a small pane that appeared on the bottom of the workspace showing errors in the current file (also see #17). When I started refactoring I couldn't come up with a good redesign for it, so it fell by the wayside in favor of the larger project-wide "Problem View."

[devoncarew]

Cool. It would be great to remove unused source, and perhaps refactor the location of existing source files. It can be a bit hard to navigate the source for people not yet familiar w/ it. There are several directories with similar names and it's not always clear where I should be looking for things.

[radicaled]

I'm trying to keep the "new" stuff in directories with component based naming:

analysis stuff in /analysis,
analysis api stuff in /analysis_api,
pub stuff in /pub
and sdk stuff in /sdk

everything else is just sort of a free-for-all right now, left over from my initial proof of concept.

I think we can do a project-wide search for class names and remove them if they don't show up in a line like this: ClassName = require './random_file' -- there's no dynamic file requiring used in the project.

[devoncarew]

Great! What's the difference between stuff that would go in analysis vs analysis_api?

[radicaled]

/analysis_api --> classes that deal with sending structured messages to the analysis server. Basically any API interfaces.

/analysis_api/completion_api.coffee --> sends the "completion.getSuggestions" request to the server, returns a promise so you can operate on the results.

/analysis_api/edit_api.coffee --> sends the "edit.format" request to the server, returns a promise so you can operate on the results.

/analysis --> general analysis stuff. The analysis toolbar, the analysis decorator, etc.