Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Can Impersonate another User and Use their Tacos #11

Closed
Radicalius opened this issue Jul 27, 2019 · 0 comments
Closed

Users Can Impersonate another User and Use their Tacos #11

Radicalius opened this issue Jul 27, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@Radicalius
Copy link
Owner

E.g.

curl \ 
-d '{"bot":false,"trigger_word":":taco:","channel_id":"TJf7cJcJjZDj3kFct","channel_name":"channel","message_id":"5xEFvg23JzH7BSPNx","timestamp":"2019-07-27T21:18:35.319Z","user_id":"F9YKW787Y4bbtYuJu","user_name":"zac","text":":taco: @user"}' \
localhost:4567/taco?channel=channel

Possible Solution:

  • Server and integration script share a secret key
  • Integration script sends hash(taco_giver || taco_receiver || secret_key || timestamp) in the headers for requests to /taco
  • Server computes the hash and rejects the request if it doesn't match
@Radicalius Radicalius added the bug Something isn't working label Jul 27, 2019
Radicalius pushed a commit that referenced this issue Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant