replication: create rad/id and rad/self symref #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjg
reviewed
Jun 18, 2021
kim
previously approved these changes
Jun 19, 2021
FintanH
force-pushed
the
finto/rad-id-symref
branch
from
a125d37
to
723a08b
Compare
`get_user` should return `Person`, and we add `get_local` which gets a `LocalIdentity`. Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
FintanH
force-pushed
the
finto/rad-id-symref
branch
from
723a08b
to
39cd7fb
Compare
xla
previously approved these changes
Jun 25, 2021
librad/src/git/replication.rs
Outdated
| fn adopt_rad_self(storage: &Storage, urn: &Urn, peer: PeerId) -> Result<(), Error> { | ||
| let rad_self = Reference::rad_self(Namespace::from(urn), peer); | ||
|
|
||
| // We only need to crate the rad/id there's a rad/self |
There was a problem hiding this comment.
Suggested change
| // We only need to crate the rad/id there's a rad/self | |
| // We only need to create the rad/id there's a rad/self |
alexjg
previously approved these changes
Jun 25, 2021
Before this patch a `rad/self` would be replicated, however, there would be no corresponding `rad/id` at the top-level. This patch introduces the adding of the `rad/id` and creating a symbolic ref between `rad/id` and `rad/self` for each tracked peer. Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
FintanH
force-pushed
the
finto/rad-id-symref
branch
from
39cd7fb
to
a98218d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #708
We add
rad/idat the top level and create a symbolic ref betweenrad/idandrad/selffor each tracked peer.In the
daemoncode I changed theget_userfunction to return a regularPersondocument and addedget_localfor getting the local identity.I chose to add the test to
daemon/replicationbecause I thought it would have fitted with themenagetests but they're no bueno right now.