Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

fix(ui): handle special symbols in filenames #1028

Merged
merged 11 commits into from Oct 20, 2020
Merged

fix(ui): handle special symbols in filenames #1028

merged 11 commits into from Oct 20, 2020

Conversation

rudolfs
Copy link
Member

@rudolfs rudolfs commented Oct 13, 2020 •
edited

  • add tests
  • handle backslash faux\path

Closes: #1021.

@rudolfs rudolfs added this to the β1 milestone Oct 13, 2020
@rudolfs rudolfs added this to To do in β1 Release Preparation via automation Oct 13, 2020
@rudolfs rudolfs self-assigned this Oct 13, 2020
@xla
Copy link
Contributor

xla commented Oct 13, 2020

Refs: #1021.

Does it not close the issue?

@xla xla removed this from To do in β1 Release Preparation Oct 13, 2020
@xla xla removed this from the β1 milestone Oct 13, 2020
@rudolfs
Copy link
Member Author

rudolfs commented Oct 13, 2020

Does it not close the issue?

Switched to closes.

@rudolfs rudolfs changed the title fix(ui): handle special symbols in filenames better fix(ui): handle special symbols in filenames Oct 19, 2020
@rudolfs rudolfs marked this pull request as ready for review October 20, 2020 07:07
@rudolfs rudolfs requested review from xla and MeBrei October 20, 2020 07:07
MeBrei
MeBrei previously approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@MeBrei MeBrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

cypress/integration/project_source_browsing.spec.js Outdated Show resolved Hide resolved
@rudolfs
Update cypress/integration/project_source_browsing.spec.js
e16d7ff 
Co-authored-by: Merle Breitkreuz <merle@monadic.xyz>
xla
xla approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔲 🌝 💁 🏝

ui/src/source.ts
@@ -264,7 +264,7 @@ const update = (msg: Msg): void => {
query: {
peerId: msg.peerId,
revision: msg.revision,
path: msg.path,
path: encodeURIComponent(msg.path),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, big gains!

@rudolfs rudolfs merged commit 21c5f62 into master Oct 20, 2020
@rudolfs rudolfs deleted the rudolfs/fix-source-browser branch October 20, 2020 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xla xla xla approved these changes

@MeBrei MeBrei MeBrei approved these changes

Assignees

@rudolfs rudolfs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening a .patch file in the source browser leads to error
3 participants
@rudolfs @xla @MeBrei