fix(ui): always tracked toggle for projects

[xla]

Until we introduce explicit untracking of projects, whenever we show
a project page it is inherently tracked. Therefore the track toggle
should be in tracked state and the unfollow action disabled.

Closes #1045

---

[brandonhaslegs]

Maybe should just remove the button until you can interact with it? Just having this network icon in a grey box that's not clickable will be pretty confusing.

[juliendonck]

I wonder if it's not better having a tooltip explaining that you can't unfollow at the moment then to remove the functionality entirely.

[FintanH]

What's this button even for? 😂

[xla]

What's this button even for? joy

@FintanH To untrack a project at the point we have it that functionality supported.

[FintanH]

To untrack a project at the point we have it that functionality supported.

Does that mean remove it from your device completely?

[xla]

Does that mean remove it from your device completely?

TBD I guess, but I assume something along those lines. As currently "tracking" is equivalent to having a subtree in your monorepo refs.

[FintanH]

Somebody call me when we need this 🤙

[xla]

Following up on the discussions we had, the inactive toggle is always expanded and says "Following":

When testing it in conjunction with the peer selector there is some funkiness with z-indexing so the selector now expands to the left:

[rudolfs]

There's a weird border on hover:

vs non-hover

[rudolfs]

I can still follow/unfollow my project, the button isn't disabled. Was that behaviour also discussed, if so, what was the outcome?

[xla]

I can still follow/unfollow my project, the button isn't disabled. Was that behaviour also discussed, if so, what was the outcome?

Yeah just discovered that, will fix and see if I can tame the border/box-shadow.

[rudolfs]

There's still a 1px border on hover, I think it should not be there:

This removes it:

diff --git a/ui/DesignSystem/Component/TrackToggle.svelte b/ui/DesignSystem/Component/TrackToggle.svelte
index 7edb809..ef4f126 100644
--- a/ui/DesignSystem/Component/TrackToggle.svelte
+++ b/ui/DesignSystem/Component/TrackToggle.svelte
@@ -42,12 +42,10 @@
   .toggle.hover {
     border: 1px solid var(--color-secondary-level-2);
     background-color: var(--color-secondary-level-2);
-    box-shadow: 0 0 0 1px var(--color-secondary-level-2);
   }
   .toggle.active {
     border: 1px solid var(--color-secondary-level-1);
     background-color: var(--color-secondary-level-1);
-    box-shadow: 0 0 0 1px var(--color-secondary-level-1);
   }
   .toggle.tracking {
     border: 1px solid var(--color-foreground-level-3);
@@ -57,18 +55,15 @@
   .toggle.tracking.hover {
     border: 1px solid var(--color-foreground-level-2);
     background-color: var(--color-foreground-level-2);
-    box-shadow: 0 0 0 1px var(--color-foreground-level-2);
     color: var(--color-foreground-level-6);
   }
   .toggle.tracking.hover.warning {
     color: var(--color-background);
     border: none;
-    box-shadow: none;
   }
   .toggle.tracking.active {
     border: 1px solid var(--color-foreground-level-2);
     background-color: var(--color-foreground-level-2);
-    box-shadow: 0 0 0 1px var(--color-foreground-level-2);
     color: var(--color-foreground-level-4);
   }
   .left {

[rudolfs]

Neat!

[brandonhaslegs]

Maybe should change the cursor on the button to not-allowed and add a tooltip that says why I can't unfollow a project.

[xla]

Maybe should change the cursor on the button to not-allowed and add a tooltip that says why I can't unfollow a project.

Captured in #1061