This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
fix(proxy): check waiting room has urn #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During gossip announcements of Has, we would always mark the RadUrn as Found in the WaitingRoom, but the WaitingRoom might not necessarily have been looking for this RadUrn. So we first check that the WaitingRoom indeed `has` the RadUrn before continuing on.
rudolfs
approved these changes
Oct 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154
During gossip announcements of Has, we would always mark the RadUrn as
Found in the WaitingRoom, but the WaitingRoom might not necessarily have
been looking for this RadUrn. So we first check that the WaitingRoom
indeed
hasthe RadUrn before continuing on.