This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
fix(proxy): add include to project creation #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add include setup during project creation to ensure that we have one for when we need to update it. Once we track and untrack peers we should update the include file.
|
Looks like the tests might be flakey: https://buildkite.com/monadic/radicle-upstream/builds/6261#080d374b-b207-4ed1-9c7a-1a1889cd068a |
When we fetch or when have applied a change we know that a peer that we tracked but not received changes for yet should now exist in our repo. This is the opportune time to update the include file for this project and add the peer's handle as a remote.
It turns out can use the PeerEvents to see if we Applied any changes.
rudolfs
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1201
WIP: I have a suspicion this won't quite work. Need to test it out with the seed and a peer.Tested and twerks.
We add include setup during project creation to ensure that we have one
for when we need to update it.
Once we track and untrack peers we should update the include file.