Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

feat(ui): log unhandled exceptions #1250

Merged
merged 1 commit into from Nov 13, 2020
Merged

Conversation

geigerzaehler
Copy link
Contributor

As part of #1187 we show notifications for all unhandled exceptions.

Signed-off-by: Thomas Scholtes <thomas@monadic.xyz>
@geigerzaehler geigerzaehler self-assigned this Nov 13, 2020
@geigerzaehler geigerzaehler added feature Something that doesn't exist yet ui labels Nov 13, 2020
@geigerzaehler geigerzaehler marked this pull request as ready for review November 13, 2020 11:47
@xla xla added this to the Housekeeping milestone Nov 13, 2020
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐤 🍤 🏂 🕜

Copy link
Contributor

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ProjectRequestFailure = "ProjectRequestFailure",
SessionFetchFailure = "SessionFetchFailure",
UnexpectedProxyExit = "UnexpectedProxyExit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to do the rename you mentioned in the docs PR now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do separately

@geigerzaehler geigerzaehler merged commit 79d2372 into master Nov 13, 2020
@geigerzaehler geigerzaehler deleted the thomas/unhandled-errors branch November 13, 2020 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Something that doesn't exist yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants