This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
fix(ui): move go to profile to isExperimental
#1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliendonck
requested review from
rudolfs and
MeBrei
and removed request for
rudolfs
juliendonck
changed the title
go to profile to isExperimentalgo to profile to isExperimental
|
I wonder if we should show the collapse icon in the expanded dropdown as well to prevent it from "jumping" around?
diff --git a/ui/Screen/Project/PeerSelector.svelte b/ui/Screen/Project/PeerSelector.svelte
index 791d80a1..2d2a33ba 100644
--- a/ui/Screen/Project/PeerSelector.svelte
+++ b/ui/Screen/Project/PeerSelector.svelte
@@ -217,6 +217,9 @@
<Icon.ArrowBoxUpRight />
</div>
</Tooltip>
+ {:else}
+ <Icon.ChevronUpDown
+ style="margin-left: 0.5rem; vertical-align: bottom; fill: var(--color-foreground-level-4)" />
{/if}
</div>
{/each} |
rudolfs
approved these changes
Nov 17, 2020
geigerzaehler
approved these changes
Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we can't resolve the profiles of contributors yet (only of the maintainer) from the peerselector, we've decided to move it to isExperimental for now.
Closes #1254