This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
New step counter #210
Merged
New step counter #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahscott
approved these changes
Mar 5, 2020
rudolfs
previously requested changes
Mar 5, 2020
MeBrei
force-pushed
the
merle/new-step-counter
branch
from
c578ae4
to
34144c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All modals with step counters will use this new design (user registration, org registration, ...).
The current implementation of the
StepCounterIcon breaks with the convention of overwriting the color by passingstyle. If it becomes necessary to do so, we could pass two style parameters, egouterStyle,innerStyle(I would like to avoid splitting up the icon and overlapping it via positioning).Prepares #202