This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Extend Avatar with new fallback data #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once we also have the fallback avatars for Orgs I am hoping that the Avatar component can be refactored so that the full Identity or Org data is passed as one prop and Avatar knows how to handle it. |
@MeBrei Generally the surface should only expect the minimum amount of information needed to fullfill it's purpose. Passing entire objects lends itself to deep coupling. Instead it should only require what is necesary to render itself correctly. |
xla
suggested changes
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #218 avatar fallbacks are provided for identity and can be queried with a handle. This PR extends the
Avatarcomponent to use the fallback avatar or query it if a handle is provided. This prepares #216 and #211.Note that most of the Avatars in the app are currently still using hardcoded imgUrl which should be replaced when refactoring the components.