Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

feat: org explore screen #2450

Merged
merged 59 commits into from Oct 18, 2021
Merged

feat: org explore screen #2450

merged 59 commits into from Oct 18, 2021

Conversation

juliendonck
Copy link
Member

@juliendonck juliendonck commented Oct 1, 2021 •
edited

Creates an Org Explore Page and adds a sidebar to the OrgScreen

Screenshot 2021-10-04 at 08 05 14

Screenshot 2021-10-04 at 08 05 22

todo:

  • links in sidebar don't open
  • Add a spinner to the <OrgsScreen /> while the orgs are being fetched
  • remove 9 org limit in fetch & improve cashing

juliendonck and others added 19 commits September 30, 2021 16:57
@juliendonck
wip
03081f8 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
7b84c64 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
c610af6 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@rudolfs
Get org type
6872662 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@juliendonck
Merge branch 'master' into julien/org-explore
4021fa0
@juliendonck
wip
20f10da 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
148c384 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
cde3d70 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
9840e98 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
b1f0a78 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
bcd2a84 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
982976e 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
Merge branch 'master' into julien/org-explore
311b078
@juliendonck
wip
6729608 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
wip
1db64f7 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
Merge branch 'master' into julien/org-explore
9ea47cf
@juliendonck
Merge branch 'julien/org-explore' of github.com:radicle-dev/radicle-u…
c78fcf6 
…pstream into julien/org-explore
@juliendonck
wip
6aeb78a 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
resolve linting errors
7b42d22 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck juliendonck marked this pull request as ready for review October 5, 2021 13:45
@juliendonck juliendonck requested a review from a team as a code owner October 5, 2021 13:45
@juliendonck
Copy link
Member Author

@geigerzaehler @rudolfs this is a monster, and as per usual there's a few things mixed in there. One thing, I don't know how to resolve the linting issue about the owner.members not being the right type.

@juliendonck
Copy link
Member Author

@brandonhaslegs if you want to give this a once over from a design pov that would be great

@rudolfs
Fixup
3307229 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@brandonhaslegs
Copy link
Contributor

brandonhaslegs commented Oct 5, 2021 •
edited

Doesn't load for me.
image

Every time I try to load the page, the wallet error appears.
image

@rudolfs
Copy link
Member

rudolfs commented Oct 5, 2021

Doesn't load for me.

You have to connect your wallet first.

@brandonhaslegs
Copy link
Contributor

You have to connect your wallet first.

Why do you have to connect your wallet? Aren't you jut browsing all orgs, like you are on https://app.radicle.network/orgs? I don't have to connect my wallet to see those orgs…

@rudolfs
Copy link
Member

rudolfs commented Oct 5, 2021 •
edited

Why do you have to connect your wallet? Aren't you jut browsing all orgs, like you are on https://app.radicle.network/orgs? I don't have to connect my wallet to see those orgs…

We infer the network you're connected to from your wallet. I think we also need to be connected to the wallet to get ENS related data from infura. Some of these things we might be able to work around and not need anymore in the future.

I think we can work around it.

@rudolfs
Merge branch 'master' into julien/org-explore
ea07104 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs
Improve quorum wording
4cb1690 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs
Revert "Improve quorum wording"
a0d3b96 
This reverts commit 4cb1690.
@rudolfs
Improve quorum wording take 2
0ed9385 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs
Fixup
0c78e11 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs
Show "all" orgs on Rinkeby
b3640bd 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs rudolfs mentioned this pull request Oct 14, 2021
Merged
geigerzaehler
geigerzaehler reviewed Oct 18, 2021
View reviewed changes
ui/src/org/theGraphApi.ts Outdated Show resolved Hide resolved
ui/src/org/theGraphApi.ts Outdated Show resolved Hide resolved
ui/App/OrgsScreen.svelte Outdated Show resolved Hide resolved
ui/App/OrgsScreen.svelte Outdated Show resolved Hide resolved
ui/src/org/theGraphApi.ts Outdated Show resolved Hide resolved
ui/App/OrgsScreen.svelte Outdated Show resolved Hide resolved
ui/App/OrgsScreen.svelte Outdated Show resolved Hide resolved
ui/App/OrgsScreen.svelte Outdated Show resolved Hide resolved
ui/App/WalletScreen.svelte Outdated Show resolved Hide resolved
juliendonck and others added 10 commits October 18, 2021 14:04
@juliendonck
use functions to access values
3ff17d7 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
typescript knows what is unreachable
a702411 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
remove wrong datacy
373e630 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
align container alignment
d95a3d7 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
point emptystate to right folder
02238bd 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@juliendonck
reduce loading screen size
51e139b 
Signed-off-by: Julien Donck <hello@juliendonck.com>
@rudolfs
Rename function
2a10ca1 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@geigerzaehler @juliendonck
fix: ignore RUSTSEC-2020-0071
194d9bd 
We ignore [RUSTSEC-2020-0071][1] because we’re likely unaffected and
this probably isn’t going to be fixed any time soon.

[1]: https://rustsec.org/advisories/RUSTSEC-2020-0071

Signed-off-by: Thomas Scholtes <geigerzaehler@axiom.fm>
@rudolfs
Move mutation to callsite
ed45990 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs
Fixup
7fb9469 
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
rudolfs
rudolfs approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@rudolfs rudolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rudolfs rudolfs changed the title org explore screen feat: org explore screen Oct 18, 2021
@juliendonck juliendonck merged commit 574aac6 into master Oct 18, 2021
@juliendonck juliendonck deleted the julien/org-explore branch October 18, 2021 14:17
@rudolfs rudolfs mentioned this pull request Dec 17, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rudolfs rudolfs rudolfs approved these changes

@geigerzaehler geigerzaehler geigerzaehler approved these changes

@brandonhaslegs brandonhaslegs Awaiting requested review from brandonhaslegs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juliendonck @brandonhaslegs @rudolfs @geigerzaehler