This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Implement naive tx cache #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xla
requested review from
cloudhead,
garbados,
geigerzaehler,
NunoAlexandre and
MeBrei
MeBrei
reviewed
Mar 24, 2020
| projectName, | ||
| orgId | ||
| } | ||
| }, |
There was a problem hiding this comment.
It is a bit confusing to request a specific content although we are asserting that there will be no transactions
There was a problem hiding this comment.
Still working on meaningful tests, this is wip.
cloudhead
reviewed
Mar 24, 2020
cloudhead
reviewed
Mar 24, 2020
proxy/src/registry.rs
Outdated
| }) | ||
| }; | ||
|
|
||
| self.transactions.insert(tx.id, tx.clone()); |
There was a problem hiding this comment.
Might be a good idea to implement a self.submit_tx proxy function that calls self.client.submit_transaction and inserts the tx in the cache. That way we don't ever forget to cache stuff.
There was a problem hiding this comment.
Unfortunately that is not doable at the moment as Message in the registry is a trait with a static method. So we can't really pull the code out that constructs registry transactions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244