feat(proxy): extend project with org/user relation #251
Conversation
xla
requested review from
cloudhead,
rudolfs,
garbados,
NunoAlexandre and
MeBrei
| match registration { | ||
| project::Registration::Org(org_id) => { | ||
| Some(ProjectRegistration::Org(OrgRegistration { | ||
| org_id: juniper::ID::new(org_id.to_string()), |
There was a problem hiding this comment.
Could we return the actual org/user instead of just the id and maybe mock out some sample data?
So far it looks like we'll need:
- user handle / org name
- avatarUrl
- avatarFallback
There was a problem hiding this comment.
To mock this meaningfully we need orgs first. For the rest we have to decide what behaviour we want as:
- neither user nor orgs have avatar urls
- only orgs have a fallback avatar
- only users maybe have an coco identity attested to them
- which only maybe is available at the time of query
What we can do for now is to show the foo / bar info with a returned avatar from the avatar query. How we control that a project appears as registered is open for discussion, it could be a query parameter that we allow for now.
There was a problem hiding this comment.
neither user nor orgs have avatar urls
Good point, forgot about that.
only orgs have a fallback avatar
Why wouldn't a user have a fallback avatar?
What we can do for now is to show the foo / bar info with a returned avatar from the avatar query.
Deal.
There was a problem hiding this comment.
Why wouldn't a user have a fallback avatar?
AFAIK only identities have fallback avatar, the handle more specifically. @cloudhead and @MeBrei can give more context.
There was a problem hiding this comment.
I wonder why would we otherwise have user emojis:
https://github.com/radicle-dev/radicle-upstream/blob/master/proxy/src/avatar.rs#L52-L59
There was a problem hiding this comment.
I guess this will be answered in: #230.
There was a problem hiding this comment.
@rudolfs We have user emojis for the identity handles.
There was a problem hiding this comment.
Expanded on in #230 (comment)
Closes #245