Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

feat: transactions through REST API #305

Merged
merged 3 commits into from Apr 23, 2020
Merged

feat: transactions through REST API #305

merged 3 commits into from Apr 23, 2020

Conversation

xla
Copy link
Contributor

@xla xla commented Apr 23, 2020

Follow-up to #293
Related to #225

@xla xla added proxy feature Something that doesn't exist yet labels Apr 23, 2020
@xla xla self-assigned this Apr 23, 2020
MeBrei
MeBrei suggested changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@MeBrei MeBrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Looks great! Just a few comments about the choice of wording.

ui/DesignSystem/Component/Transaction.svelte Outdated Show resolved Hide resolved
ui/DesignSystem/Component/Transaction.svelte Show resolved Hide resolved
ui/DesignSystem/Component/Transaction/Center.svelte Show resolved Hide resolved
ui/DesignSystem/Component/Transaction.svelte Outdated Show resolved Hide resolved
rudolfs
rudolfs reviewed Apr 23, 2020
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@xla xla merged commit 77e6ec5 into master Apr 23, 2020
@xla xla deleted the xla/rest-transactions branch April 23, 2020 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rudolfs rudolfs rudolfs left review comments

@MeBrei MeBrei MeBrei approved these changes

@cloudhead cloudhead Awaiting requested review from cloudhead

@sarahscott sarahscott Awaiting requested review from sarahscott

Assignees

@xla xla

Labels
feature Something that doesn't exist yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xla @rudolfs @sarahscott @MeBrei