fix: bundle missing library libhogweed #351
Conversation
1901ae4
to
1a54c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure what adding the shared library to extraFiles
does. Does it install the library to /usr/lib
? This might mess up the users system.
An alternative would be to link the nettle
package statically with the vendored
feature. This links nettle statically. However this might also increase build times.
It might also be prudent to include the other libraries like `libnettle.so.7
@geigerzaehler: as we're using electron bundler for distribution, I assume it would bundle the files with the package somehow. Not sure what it uses under the hood. I don't expect it to actually write stuff into your filesystem, and assume that the I thought the comment on the builder thread was worth giving a shot before spending more time to figure this out. @cloudhead also suggested looking into AppImage documentation. There's an option to bundle libs:
But would have to investigate how exactly bundler works under the hood for this to be of any help. |
@geigerzaehler could you give this build a try on your machine (assuming that you remove the nettle libs from your system temporarily): https://buildkite.com/monadic/radicle-upstream/builds/2103#76b36227-4c83-4adb-ba59-6e8783da7cac? |
The app image is still not working.
I have |
51541de
to
634ca2e
Compare
Ok, I changed it to |
So now we got
|
@rudolfs this fixed it for me! |
Trying out the "official" solution: electron-userland/electron-builder#2732.
Closes #112