feat(proxy): coco ascension #414

xla · 2020-05-22T01:32:07Z

Fixes #434

FintanH

Laying down some thoughts to track improvements, changes, and questions :)

proxy/src/coco.rs

proxy/src/coco/source.rs

proxy/src/http/control.rs

proxy/src/coco.rs

FintanH · 2020-05-22T08:37:03Z

We're currently not verifying any of the entities. We should :)

proxy/src/coco.rs

allows us to pass around a single type and define functions in terms of the capabilities. This meant that I cleared out a lot of passing around of Paths, and instead it passed around the Client. Fixed up errors to use thiserror.

means that we can implement the functionality via the PeerApi rather than have a Client trait. WIP: The tests compile but fail due to some secret key issues.

xla

DOPE!!!!!!!!!!!!!!

proxy/src/coco.rs

proxy/src/http/control.rs

proxy/src/http/source.rs

proxy/src/main.rs

Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>

FintanH

All good from my perspective 😄

rudolfs

Awesome stuff! 🏖️ 🦺 ✌️

Biggest question is: why do my project disappear after I restart the app?

Inlined a couple more questions.

rudolfs · 2020-06-15T07:49:16Z

.buildkite/Dockerfile

@@ -15,4 +15,3 @@ RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
 RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
 RUN apt-get -y update
 RUN apt-get -y install yarn
-RUN rustup component add clippy --toolchain nightly-2020-02-05-x86_64-unknown-linux-gnu


Does this mean we're not installing the rust toolchain in the image and are instead downloading it every time? If that's true, it will blow up on CI after a while.

Nope, it's just part of the base image.

And does this registry base image have the same rust-toolchain version the coco dependency? Will both dependencies always be on the same version?

We currently don't actively coordinate the toolchain versions across projects. Historically registry was the first to adopt nightly, so we have been trailing theirs. They also off the base image conveniently. This could be raised in radicle-decisions as a cross-engineering concern.

package.json

proxy/src/http/control.rs

ui/Screen/ProjectCreation.svelte

yarn.lock

rudolfs · 2020-06-15T09:37:51Z

I also noticed that the URNs are not consistent anymore:

FintanH · 2020-06-15T09:49:30Z

Biggest question is: why do my project disappear after I restart the app?

@rudolfs: is this happening running the application in "production" mode? It might be something I need you to walk myself or xla through 👀

rudolfs · 2020-06-15T09:52:11Z

@FintanH what is the "production mode"? I start it as I've always done with yarn start, create my projects, quit the app and start it again with yarn start.

FintanH · 2020-06-15T09:53:56Z

@FintanH what is the "production mode"? I start it as I've always done with yarn start, create my projects, quit the app and start it again with yarn start.

That sounds like "production mode" to me 😅 There's a flag that checks are we testing or not and depending on that the setup for coco is different, i.e. uses tmp dirs.

I would expect the projects to be persisted so we should look into that.

rudolfs · 2020-06-15T11:11:06Z

I would expect the projects to be persisted so we should look into that.

xla: The reason the state is wiped on restart is that we fake the resolvers with an in-memory hashmap for now.

Will be addressed in: #456

All points addressed.

xla added proxy feature Something that doesn't exist yet labels May 22, 2020

xla assigned xla and FintanH May 22, 2020

FintanH reviewed May 22, 2020

View reviewed changes

proxy/src/coco.rs Outdated Show resolved Hide resolved

FintanH reviewed May 22, 2020

View reviewed changes

proxy/src/coco.rs Outdated Show resolved Hide resolved

FintanH and others added 10 commits May 28, 2020 10:41

WIP: Bumping link and surf

cae4fd2

Pass in keystore and resolver

d83a964

Fixing up source

933be02

Use thiserror for deriving Error

264824e

Use Coco type for bundling. Pass in User for init

c06d29f

Rearrange public traits

61cbf1b

Banish source related fns to the lower depths of module hell

59431e3

This one is for finto

7a7f427

Docs to appease clippy

b8aaaf7

FintanH force-pushed the coco-ascension branch from bfe12f0 to b8aaaf7 Compare May 28, 2020 09:57

FintanH added 2 commits June 2, 2020 15:59

Update the librad revision so we can access the PeerApi changes. This

175f270

means that we can implement the functionality via the PeerApi rather than have a Client trait. WIP: The tests compile but fail due to some secret key issues.

Remove keystore deps (for now). Run cargo update

e5d5606

FintanH added this to In progress in Respository Selector Jun 4, 2020

FintanH added 2 commits June 4, 2020 13:59

Get a testing version of librad integration up and running

ceead45

Format code

0ecd280

xla commented Jun 4, 2020

View reviewed changes

FintanH and others added 5 commits June 4, 2020 20:06

Remove C parameter

ac4a6ac

Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>

Order imports

9771e6f

Return Surf Repo

d0728c5

Clean up lifetimes

8f594a7

Just return Project, since RadUrns can be retrieved from them.

c25da75

xla added 3 commits June 11, 2020 19:56

Remove last trace of Peer

af48497

Review follow-ups

e33fb71

Merge branch 'master' into coco-ascension

20781e2

FintanH added this to In progress in User Identity Jun 12, 2020

Merge branch 'master' into coco-ascension

600f29b

xla marked this pull request as ready for review June 15, 2020 07:43

FintanH mentioned this pull request Jun 15, 2020

Integrate Resolvers #456

Closed

This was referenced Jun 15, 2020

Clean-up coco module #487

Closed

Cover coco module with tests #488

Closed

FintanH approved these changes Jun 15, 2020

View reviewed changes

rudolfs previously requested changes Jun 15, 2020

View reviewed changes

Merge branch 'master' into coco-ascension

61b8f97

Revert accidental package.json changes

dd3a832

rudolfs mentioned this pull request Jun 15, 2020

Make all project URNs consistent #491

Closed

Only display local branches for local state

bbbc4ca

xla linked an issue Jun 15, 2020 that may be closed by this pull request

Create new project branch selector shows remote branches #434

Closed

xla requested a review from rudolfs June 15, 2020 11:36

rudolfs approved these changes Jun 15, 2020

View reviewed changes

xla merged commit 18acd59 into master Jun 15, 2020

xla deleted the coco-ascension branch June 15, 2020 12:32

rudolfs mentioned this pull request Jun 15, 2020

fix(ui): fix branch selector for local project creation #439

Closed

rudolfs moved this from In progress to Done in Respository Selector Jun 16, 2020

FintanH moved this from In progress to Done in User Identity Jun 23, 2020

FintanH moved this from In progress to Done in Link-Proxy Integration Jun 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(proxy): coco ascension #414

feat(proxy): coco ascension #414

xla commented May 22, 2020 •

edited

FintanH left a comment

FintanH commented May 22, 2020

xla left a comment

FintanH left a comment

rudolfs left a comment

rudolfs Jun 15, 2020

xla Jun 15, 2020

rudolfs Jun 15, 2020

xla Jun 15, 2020

rudolfs commented Jun 15, 2020

FintanH commented Jun 15, 2020

rudolfs commented Jun 15, 2020

FintanH commented Jun 15, 2020

rudolfs commented Jun 15, 2020

feat(proxy): coco ascension #414

feat(proxy): coco ascension #414

Conversation

xla commented May 22, 2020 • edited

FintanH left a comment

Choose a reason for hiding this comment

FintanH commented May 22, 2020

xla left a comment

Choose a reason for hiding this comment

FintanH left a comment

Choose a reason for hiding this comment

rudolfs left a comment

Choose a reason for hiding this comment

rudolfs Jun 15, 2020

Choose a reason for hiding this comment

xla Jun 15, 2020

Choose a reason for hiding this comment

rudolfs Jun 15, 2020

Choose a reason for hiding this comment

xla Jun 15, 2020

Choose a reason for hiding this comment

rudolfs commented Jun 15, 2020

FintanH commented Jun 15, 2020

rudolfs commented Jun 15, 2020

FintanH commented Jun 15, 2020

rudolfs commented Jun 15, 2020

xla commented May 22, 2020 •

edited