This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xla
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚇 🎊 🎋 🕹
rudolfs
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Inlined some suggestions.
Would also suggest to apply this patch:
diff --git a/ui/Screen/IdentityCreation.svelte b/ui/Screen/IdentityCreation.svelte
index fc3f077..cfc13b4 100644
--- a/ui/Screen/IdentityCreation.svelte
+++ b/ui/Screen/IdentityCreation.svelte
@@ -16,9 +16,20 @@
store.set(State.Welcome);
};
+ const truncateUrn = message => {
+ let urn = message.match(/(rad:git:\w{59})/)[1];
+
+ if (urn) {
+ return message.replace(/(rad:git:\w{59})/, urn.substr(-5));
+ } else {
+ return message;
+ }
+ };
+
const onError = event => {
- notification.error(`Could not create identity: ${event.detail}`);
- pop();
+ notification.error(
+ `Could not create identity: ${truncateUrn(event.detail.message)}`
+ );
};
const complete = redirectPath => {
diff --git a/ui/Screen/IdentityCreation/Form.svelte b/ui/Screen/IdentityCreation/Form.svelte
index bb6d1e0..b014c41 100644
--- a/ui/Screen/IdentityCreation/Form.svelte
+++ b/ui/Screen/IdentityCreation/Form.svelte
@@ -63,7 +63,7 @@
$: if ($store.status === remote.Status.Success) {
dispatch("success");
} else if ($store.status === remote.Status.Error) {
- dispatch("error");
+ dispatch("error", {message: $store.error.message});
}
</script>
Before (the pop()
sometimes causes the error to not show up):
key, | ||
&kalt, | ||
&repo_path, | ||
"fakie-nose-kickflip-backside-180-to-handplant", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
Co-authored-by: Rūdolfs Ošiņš <rudolfs@osins.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on radicle-dev/radicle-link#229
Fixes #576
Closes #548
This integrates the use of
rad/self
in the monorepo. This means when we create an identity, we set the defaultrad/self
in the peer to thatUser
.We can now filter the projects by the
rad/self
of theProject
is the same as the defaultrad/self
. This is demonstrated in test_list_projects