This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FintanH
force-pushed
the
fintan/fetch-changes
branch
from
September 1, 2020 14:11
27ae6c3
to
b0f3a39
Compare
Adding fetch to the set of methods on Api. This allows us to contact a peer and fetch any changes. We test this by doing exactly that exchange, where one peer commits and the other follows up with a fecth.
xla
suggested changes
Sep 1, 2020
Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>
xla
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😇 🕯 🐥 🔆
rudolfs
approved these changes
Sep 1, 2020
sarahscott
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #845
Adding fetch to the set of methods on Api. This allows us to contact a
peer and fetch any changes. We test this by doing exactly that exchange,
where one peer commits and the other follows up with a fecth.