This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
feat(ui): project name formatting #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahscott
force-pushed
the
sos/project-name-dashes
branch
from
de05ccc
to
146dab7
Compare
xla
reviewed
Sep 20, 2020
There was a problem hiding this comment.
Nothing to add to @NunoAlexandre observations, happy to approve once addressed. Test needs to be looked at.
|
I'm wondering whether we should also add this to the handle input in onboarding as well to keep things consistent. That input also disallows spaces. \cc @brandonhaslegs @juliendonck
|
yes :) |
rudolfs
suggested changes
Sep 22, 2020
|
Other than the skipped tests works and looks great! |
Co-authored-by: Rūdolfs Ošiņš <rudolfs@osins.org>
rudolfs
approved these changes
Sep 23, 2020
MeBrei
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces spaces with dashes for new project names; unit-tests name formatting
Closes #529