Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_astropy_init.py uses deprecated functions #119

Closed
jfoster17 opened this issue Nov 14, 2023 · 4 comments
Closed

_astropy_init.py uses deprecated functions #119

jfoster17 opened this issue Nov 14, 2023 · 4 comments

Comments

@jfoster17
Copy link

In _astropy_init.py, this package calls and uses

from astropy.config.configuration import (
        update_default_config,
        ConfigurationDefaultMissingError,
        ConfigurationDefaultMissingWarning)

But both update_default_config and ConfigurationDefaultMissingWarning are deprecated since astropy 5.0 and have been removed in the latest dev version of astropy, causing import errors for this package.

@keflavich
Copy link
Contributor

@jfoster17 I don't suppose you know the easy immediate fix? I think we need to migrate the underlying package infrastructure to the more modern astropy stuff, but I don't have that process readily to mind.

@jfoster17
Copy link
Author

I'm afraid I don't know the best way to fix/update this. I'm not really up-to-date on astropy -- but I am pinging @astrofrog since this is causes our glue test suite to fail for the latest astropy dev versions.

@astrofrog
Copy link
Member

Looking into it now!

@astrofrog
Copy link
Member

Fixed in #120 and pvextractor v0.4 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants