Updates to support MIR v6 file format #1416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor updates to support the newest file format for MIR.
Description
A total of four fields in the spectral window header object (
MirSpData
) have been updated to their new V6 names/types. Additionally, SMA targets now have their coordinates correcty labeled as being in the "ICRS" frame rather than FK5.Motivation and Context
The fields within the
MirSpData
class have been updated to reflect their new allocations as of the most recent update to the file format. Fields being updated were previously marked as "spare", and thus the updates should have no impact on backward compatibility of datasets (rather they simply allow various pieces of software usingMirParser
to correctly access these fields from new data sets). Note that these changes are very low level from the perspective ofUVData
-- I don't expect the average user to ever encounter these changes.The FK5/ICRS mixup was noticed only recently as part of testing related to the updated phasing memo, where thanks to the improved astrometry of both pyuvdata and the SMA online system, we were able to detect an apparent ~15 mas discrepancy between the two was traced back to this mislabeling.
Types of changes
Checklist:
New feature checklist: