Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support MIR v6 file format #1416

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Updates to support MIR v6 file format #1416

merged 3 commits into from
Mar 20, 2024

Conversation

kartographer
Copy link
Contributor

Some minor updates to support the newest file format for MIR.

Description

A total of four fields in the spectral window header object (MirSpData) have been updated to their new V6 names/types. Additionally, SMA targets now have their coordinates correcty labeled as being in the "ICRS" frame rather than FK5.

Motivation and Context

The fields within the MirSpData class have been updated to reflect their new allocations as of the most recent update to the file format. Fields being updated were previously marked as "spare", and thus the updates should have no impact on backward compatibility of datasets (rather they simply allow various pieces of software using MirParser to correctly access these fields from new data sets). Note that these changes are very low level from the perspective of UVData -- I don't expect the average user to ever encounter these changes.

The FK5/ICRS mixup was noticed only recently as part of testing related to the updated phasing memo, where thanks to the improved astrometry of both pyuvdata and the SMA online system, we were able to detect an apparent ~15 mas discrepancy between the two was traced back to this mislabeling.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (25c2ab8) to head (7cb8ec3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20807    20807           
=======================================
  Hits        20791    20791           
  Misses         16       16           
Files Coverage Δ
pyuvdata/uvdata/mir.py 100.00% <ø> (ø)
pyuvdata/uvdata/mir_meta_data.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c2ab8...7cb8ec3. Read the comment docs.

Copy link
Contributor

@e-koch e-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartographer -- One minor point regarding the MIR meta data attributes in the test. Otherwise, looks good.

pyuvdata/uvdata/tests/test_mir_parser.py Show resolved Hide resolved
@bhazelton bhazelton added UVData SMA Issues related to handling of SMA data labels Mar 20, 2024
@kartographer kartographer merged commit e59eb84 into main Mar 20, 2024
53 checks passed
@kartographer kartographer deleted the sma_dev branch March 20, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SMA Issues related to handling of SMA data UVData
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants