Handle lunar ellipsoids #1417
Merged
Handle lunar ellipsoids #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 37 37
Lines 20807 20871 +64
=======================================
+ Hits 20791 20855 +64
Misses 16 16
Continue to review full report in Codecov by Sentry.
|
| @@ -293,6 +293,7 @@ def _write_ms_antenna(self, filepath): | |||
| ant_ref_frame = "ITRF" | |||
| else: | |||
| ant_ref_frame = self._telescope_location.frame.upper() | |||
| # TODO: ask Karto what the best way is to put in the lunar ellipsoid | |||
|
@bhazelton -- note you may need to clean up some of the CI actions here related to Python 3.9 to get past the testing checks... |
bhazelton
force-pushed
the
handle_lunar_ellipsoids
branch
from
e6d1990
to
858318d
Compare
drop testing against python 3.9 because it isn't supported by astropy 6 update various minimum dependencies to get a solvable environment.
remove outdated test
bhazelton
force-pushed
the
handle_lunar_ellipsoids
branch
from
d9d8841
to
5f9f892
Compare
mkolopanis
reviewed
Mar 25, 2024
kartographer
approved these changes
Mar 25, 2024
This was referenced Apr 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for various lunar ellipsoids was recently added in lunar sky 0.2.2. This handles those changes and is required for pyuvsim moon simulations to work.
To keep track of this information, I added a new
lunar_ellipsoidattribute to LocationParameter objects (similar to how we handled theframeattribute) and I added handling to pipe it into and out of all the necessary utility functions.Note that lunar sky now requires astropy >= 6.0 so I updated that requirement, which lead to a bunch of other knock-on changes to our minimum dependencies. Most notably, astropy 6.0 doesn't support python 3.9, so I dropped it from our test suite.
Motivation and Context
Types of changes
Checklist:
New feature checklist: