Cython3 #1421
Merged
Cython3 #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
- Coverage 99.92% 99.92% -0.01%
==========================================
Files 37 37
Lines 20871 20868 -3
==========================================
- Hits 20855 20852 -3
Misses 16 16 ☔ View full report in Codecov by Sentry. |
bhazelton
reviewed
Mar 28, 2024
| @@ -19,7 +19,7 @@ dependencies: | |||
| - pytest-cases>=3.8.3 | |||
| - pytest-cov | |||
| - pytest-xdist | |||
| - cython | |||
| - cython>=3.0 | |||
There was a problem hiding this comment.
This should also be updated in the readme and maybe in setup.py?
There was a problem hiding this comment.
Good call thanks for pointing those out.
for more information, see https://pre-commit.ci
bhazelton
reviewed
Mar 29, 2024
|
oh good catch. I must have missed that when I was searching through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumps the cython version to 3.0. It's been stable since October 2023.
Not sure if it is possible to change some string thins in corr fits so i'd hold off on full PR for time being.