Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase astropy_healpix version to be compatible with astropy 6.0 #1423

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Mar 28, 2024

Description

When I updated our minimum version requirements I missed that astropy_healpix needed to be updated to be compatible with astropy>=6.0. This didn't cause errors because the import failed so tests that needed astropy_healpix were just skipped in the min_versions CI. I didn't notice that there were a lot of skipped tests in that CI.

I also made pyyaml a required dependency because it's required by astropy.

Motivation and Context

Needed for dependency consistency.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (f9d0df7) to head (590aa7a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          37       37           
  Lines       20871    20871           
=======================================
  Hits        20855    20855           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor error to fix...

ci/pyuvdata_min_deps_tests.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bhazelton!

@bhazelton bhazelton merged commit e72aad2 into main Mar 28, 2024
44 checks passed
@bhazelton bhazelton deleted the fix_astropy_healpix_version branch March 28, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants