New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blacken code and clean up test-env install, introduce pre-commit #16
blacken code and clean up test-env install, introduce pre-commit #16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 481 481
Branches 109 109
=====================================
Hits 481 481
Continue to review full report at Codecov.
|
35f3aa6
to
9f621b8
Compare
Hey Bicku Finally things calmed down a bit, an I get to review your pull request. This is really cool! Thanks a lot. Can you rebase the changes once more, with the current version of the project? Also, I'd like to try black's The deprecations are mostly gone by now, as authentication is now done with jwt-tokens instead of session cookies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to move as much as possible to setup.cfg
and reduce the number of dependencies to a minimum.
- id: black | ||
name: black | ||
language: system | ||
entry: black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the --skip-string-normalization
option here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the '
more than the "
but I hate having to switch to what each project wants even more. If we skip string normalization we'll have a mix of "
and '
pretty soon.
fe01d84
to
9ef59cc
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 78.90% 78.90%
=======================================
Files 1 1
Lines 602 602
Branches 141 141
=======================================
Hits 475 475
Misses 110 110
Partials 17 17
Continue to review full report at Codecov.
|
1732f3a
to
d0f5f66
Compare
d0f5f66
to
b005ee7
Compare
I addressed all the feedbacks except the one about |
I agree. After all that's why we want to use black. |
This PR reformats the code using black, configures isort & flake8 to match and adds pre-commit to the README as well as to the travis tests. I also took care of fixing or ignoring any issues found by flake8.
My apologies for the huge changeset, all of this does not touch/refactor any of the business logic
or logic in setup.py(it touches how requirements are read from txt files in setup.py)... The changes to .travis.yml are kept as minimal as possible.I plan on taking care of the werkzeug deprecation warnings in a future pull request and this prepares the repo to make it easy to do so. I'll also automate dependency bumping PRs once this is merged.