Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to normalize at one point only #127

Closed
erwanp opened this issue Aug 31, 2020 · 3 comments
Closed

Add option to normalize at one point only #127

erwanp opened this issue Aug 31, 2020 · 3 comments
Labels
good first issue Good for newcomers interface not related to the physics of the code post-process Related to the post-processing (ex: methods of Spectrum objects) 😎. Easy (good to start with!)
Milestone
0.15

Comments

@erwanp
Copy link
Member

erwanp commented Aug 31, 2020

Extension of previous PR :

(details)
I would make clearer the if ... then ... else here

 if len(wrange) == 2:
             blabla
 elif isinstance(wrange, (int, float)):
             blabla
  else:
             UserWarning

Originally posted by @minouHub in #122 (comment)
@erwanp erwanp added the interface not related to the physics of the code label Aug 31, 2020
@erwanp erwanp mentioned this issue Aug 31, 2020
Merged
@erwanp erwanp added the post-process Related to the post-processing (ex: methods of Spectrum objects) label Sep 1, 2020
@erwanp erwanp added good first issue Good for newcomers 😎. Easy (good to start with!) labels Mar 29, 2021
@salty-ivy
Copy link

is the issue still open?

@erwanp
Copy link
Member Author

erwanp commented Oct 11, 2022

yes

@anandxkumar anandxkumar added this to the 0.15 milestone Oct 28, 2022
@E-W-Jones E-W-Jones mentioned this issue Oct 22, 2023
Merged
@minouHub
Copy link
Collaborator

This issue was closed with #627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers interface not related to the physics of the code post-process Related to the post-processing (ex: methods of Spectrum objects) 😎. Easy (good to start with!)
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
4 participants
@erwanp @minouHub @anandxkumar @salty-ivy