Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy use of custom abundances #301

Closed
erwanp opened this issue Jun 30, 2021 · 0 comments 路 Fixed by #342
Closed

Easy use of custom abundances #301

erwanp opened this issue Jun 30, 2021 · 0 comments 路 Fixed by #342
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@erwanp
Copy link
Member

erwanp commented Jun 30, 2021

馃幆 Describe what you'd like

Make it easy to choose custom isotope abundances.
Very relevant for non-Earth atmospheres !

馃挕 Possible implementations

  • Retrieval is done in loader.py which loads HITRAN's molparams.txt. Quite easy to override this at runtime (only warning : make sure the _fetch_molecular_parameters is not re-called several times

Impact on calculations :

  • at non-eq, the calculation of the emission uses the abundance. So nothing to do; the custom abundances will be used directly.

  • the calculation of absorption is based on Linestrengths. Linestrengths scale linearly with the abundance; so a correction ratio should be introduced. ( it is isotope-based and would be efficiently implemented with the map(dict) approach used by @gagan-aryan for partition functions Qgas).

    image

    Corrections needed in linestrength_eq and linestrength_noneq


Tip : you can vote for New Features on https://feathub.com/radis/radis

@erwanp erwanp added the enhancement New feature or request label Jun 30, 2021
@erwanp erwanp added this to the 0.9.30 milestone Jul 6, 2021
@erwanp erwanp self-assigned this Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant