Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After deleting an application, rad app delete still prompts the app that was just deleted #7540

Open
1 task
ytimocin opened this issue Apr 24, 2024 · 4 comments
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged

Comments

@ytimocin
Copy link
Contributor

ytimocin commented Apr 24, 2024

Steps to reproduce

  1. Run rad init and select Yes to create application in the current directory
  2. Run rad app list and see the application
  3. Run rad app delete without specifying an application
  4. See that it is going to ask if you'd like to delete the application you saw after running rad app list
  5. Select Yes and wait for the command to run
  6. Run rad app delete again without specifying an application
  7. See that it is again going to ask you to delete the application you saw in step 2

Observed behavior

Screenshot 2024-04-24 at 16 13 31

image

Desired behavior

Second rad app delete should say There is no application to delete or something like that.

Workaround

No response

rad Version

RELEASE VERSION BICEP COMMIT
0.32.0 v0.32.0 0.32.0 1b8bd4a

Operating system

MacOS, Sonoma 14.4.1, Apple Chip

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12056

@ytimocin ytimocin added the bug Something is broken or not working as expected label Apr 24, 2024
@radius-triage-bot
Copy link

👋 @ytimocin Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

@sylvainsf
Copy link
Contributor

It does communicate that the app does not exist because it was deleted in the previous step. This is the expected behavior in the case of race conditions where someone runs the command but it was deleted by someone else.

@sylvainsf sylvainsf added the triaged This issue has been reviewed and triaged label Apr 29, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@ytimocin
Copy link
Contributor Author

I guess what I am asking is that if we should do the check of application existence before prompting Are you sure you want to delete... message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

2 participants