Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Basic Slider Excample Broken #288

Closed
pdevito3 opened this issue Dec 24, 2020 · 6 comments
Closed

Basic Slider Excample Broken #288

pdevito3 opened this issue Dec 24, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@pdevito3
Copy link

The basic example for the slider is broken. Just getting started with the component, but it looks like the Slider.Range needs to be inside the Slider.Track?

@colmtuite
Copy link
Contributor

Not sure what you mean? What's "broken" about it? It works fine.

@pdevito3
Copy link
Author

hmm already wiped it for another approach. tried repoing in codesandbox for you, but couldn't remember what I did. Does look like the base example worked though exactly as is, so it must have been something i was doing.

regardless, fwiw the docs are confusing where it says The range part. Must live inside Slider.Track. but the example isn't inside of it:

  <Slider.Root>
    <Slider.Track>
      <Slider.Thumb />
    </Slider.Track>
    <Slider.Range />
  </Slider.Root>

@colmtuite
Copy link
Contributor

In the example, the range is inside the track. I'm not sure what you mean.

Screenshot 2020-12-24 at 05 57 49

@pdevito3
Copy link
Author

sorry, i meant to link to the anatomy tag

@colmtuite colmtuite added the bug Something isn't working label Dec 24, 2020
@colmtuite
Copy link
Contributor

Ah, I see. Yep this looks like a bug. Thanks!

For future reference, the website repo is the best place to report documentation issues. Thanks.

@pdevito3
Copy link
Author

yup, apologies. thought i was in there, but must have accidentally went back to design system.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants