Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announce] VoiceOver announces incomplete changes in some situations #167

Closed
chaance opened this issue Sep 10, 2020 · 1 comment
Closed
Labels
Package: react/announce Resolution: Won't Fix This issue will not be fixed Type: Bug Confirmed bug

Comments

@chaance
Copy link
Contributor

chaance commented Sep 10, 2020

Per #133 (comment):

Seems to work pretty well although didn't announce the full sentence in Safari + Voiceover

The closest issue we could find elsewhere suggests this is a Safari bug. https://core.trac.wordpress.org/ticket/36853

I tried implementing a similar empty string fix suggested in the WordPress bug, but that doesn't work as intended in NVDA when working with stacked notifications (as a toast likely will). This may be something we can do separately in a Status package where notifications are replaced completely instead of stacked, as that it primarily where the problem lies and is most likely to occur.

Referenced in #166

@chaance chaance changed the title LiveRegion: VoiceOver announces incomplete changes in some situations Announce: VoiceOver announces incomplete changes in some situations Sep 15, 2020
@chaance chaance added the Type: Bug Confirmed bug label Dec 16, 2020
@benoitgrelard benoitgrelard changed the title Announce: VoiceOver announces incomplete changes in some situations [Announce] VoiceOver announces incomplete changes in some situations Mar 9, 2021
@benoitgrelard
Copy link
Collaborator

This primitive will be deprecated soon as it doesn't fit with our high-level use case approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react/announce Resolution: Won't Fix This issue will not be fixed Type: Bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants