Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Export component as 'Namespaced Component' #75

Closed
zernonia opened this issue Jun 27, 2023 · 2 comments · Fixed by #522
Closed

[Feature]: Export component as 'Namespaced Component' #75

zernonia opened this issue Jun 27, 2023 · 2 comments · Fixed by #522
Assignees

Comments

@zernonia
Copy link
Collaborator

zernonia commented Jun 27, 2023

Is your feature request related to a problem? Please describe.

In Radix-ui, they are using namespaced component to export all child component (including root component) as a component.

(eg: DialogRoot.vue -> Dialog.Root).

Describe the solution you'd like

We can do the same for Radix-vue too. Can check out https://github.com/xiaoluoboding/vue-command-palette/blob/main/packages/index.ts to learn how it was achievable.

(This is just a nice to have, so we don't need to import all the child component manually when building a custom component)

@khairulhaaziq
Copy link
Member

hi @zernonia , glad to have you here! yes we have considered this and think that a non-namespaced naming convention is more 'vue-like', however I think its also possible to implement both. This is still very early decision though so anything can change. We would really like to have you contribute on this, if you want, I would like to invite you to our discord server so I can get you setup

@zernonia
Copy link
Collaborator Author

After testing out using Namespaced component (while developing Primitive), it seems unintuitive for Vue user, as it is not the convention.
So will close out this ticket ya 😁

@zernonia zernonia reopened this Nov 17, 2023
@zernonia zernonia self-assigned this Nov 17, 2023
@zernonia zernonia linked a pull request Nov 17, 2023 that will close this issue
@zernonia zernonia changed the title Export component as 'Namespaced Component' [Feature]: Export component as 'Namespaced Component' Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants