Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(tooltip): disable tooltip #799

Merged
merged 10 commits into from
Apr 4, 2024

Conversation

Chrtyaka
Copy link
Contributor

Hi!👋🏻 Closes #572

Changed

TooltipProvider.vue

  • add prop disabled

TooltipRoot.vue

  • add prop disabled. Also inherits value from TooltipProvider.vue

TooltipTrigger.vue

  • move al event listeners to single object, and bind it conditionally
  • if tooltip disabled - simply unbind all listeners

Tests

  • add tests

Docs

  • update docs

Artifact

CleanShot.2024-03-31.at.4.38.52.mp4

Copy link
Collaborator

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIcely done @Chrtyaka ! LGTM! However there's a on-going discussion on the issue ticket itself, and I'll need to look at some of the consideration

Copy link
Collaborator

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Chrtyaka !! 🤩

@zernonia zernonia merged commit 3d8dcb4 into radix-vue:main Apr 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add dsiabeld prop to tooltip
2 participants