New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: theme switcher current colors #198

Merged

sadeghbarati merged 3 commits into radix-vue:dev from joshlarsen:fix-theme-color-switcher-border

Dec 2, 2023

Contributor

joshlarsen commented Dec 1, 2023 •

edited

On the theme switcher, there are a few inconsistencies in the current color indicator:

The border color of the current color indicator doesn't match the selected color. This is the behavior of the main shadcn theme switcher
The background color is also slightly off.
The tooltip background color is that of the current color rather than a dark background

This PR fixes all of these.

Before:

After

joshlarsen added 2 commits

December 1, 2023 16:04


          fix border color

3873ef1


          match bg color closer to border

5b7190d

joshlarsen changed the title ~~fix: theme switcher current color border color~~ fix: theme switcher current colors


          fix tooltip bg color

sadeghbarati approved these changes

View reviewed changes

Collaborator

sadeghbarati left a comment

Thanks

sadeghbarati merged commit c38624c into radix-vue:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment