Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Support for MonoRepos #210

Closed
selemondev opened this issue Dec 16, 2023 · 3 comments
Closed

Question: Support for MonoRepos #210

selemondev opened this issue Dec 16, 2023 · 3 comments

Comments

@selemondev
Copy link
Contributor

selemondev commented Dec 16, 2023

An issue was raised in the shadcn-vue-vscode extension regarding monorepo support by @naveeng2402.

Issue: selemondev/vscode-shadcn-vue#21 (comment)

Here are the questions asked:

  1. A clear plan for implementing the shadcn-vue on monorepos while following best practices and guidelines.

  2. A clear explanation on how to proceed when using a monorepo either by having a separate package in it or having it installed in each application.

What would be the best way of doing this?

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Dec 17, 2023

You can test it yourself (pnpm workspaces)

shadcn-vue-monorepo.zip


  • First of all, don't do this cause you have to fully understand Node moduleResolution for the ui monorepo package

  • We lose Vite HMR after using monorepo way If we want to change ui package class/styles, Vite will fully reload the page instead

  • We have to add another path to tailwind.config and content to scan the classes inside monorepo ui package


Further reading from this comment to down

#176 (comment)

@selemondev
Copy link
Contributor Author

Thanks @sadeghbarati 🔥.

@sadeghbarati
Copy link
Collaborator

Monorepo will add complexity to the project

It's a good choice if you want to build your Design System with custom logic (wrapper-around(radix-vue)) and also with Storybook

But wrapper-around(shadcn-vue(radix-vue)) I'm not sure about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants