Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tags input #328

Merged
merged 9 commits into from
Feb 15, 2024
Merged

feat: tags input #328

merged 9 commits into from
Feb 15, 2024

Conversation

sadeghbarati
Copy link
Collaborator

@sadeghbarati sadeghbarati commented Feb 5, 2024

Can't figure out how to create Multiple Combobox with TagsInput can you do it in TagsInputComboDemo.vue? @zernonia 馃檹

https://183b3d8d.shadcn-vue.pages.dev/docs/components/tags-input

Copy link

github-actions bot commented Feb 5, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: 74a40a53
Status: 鈿★笍 Deployment in progress...
Preview URL: https://236f4964.shadcn-vue.pages.dev
Branch Preview URL: https://236f4964.shadcn-vue.pages.dev

@zernonia
Copy link
Contributor

zernonia commented Feb 7, 2024

Thanks @sadeghbarati . Using the current Combobox with TagsInput doesn't quite make sense. It's behave differernt as per the example in radix-vue.

I'm gonna try and compose a different demo of TagsInput

@zernonia
Copy link
Contributor

zernonia commented Feb 7, 2024

Updated the demo. You can check it here @sadeghbarati

We just need to update the description abit then I think this PR is ready!

@sadeghbarati
Copy link
Collaborator Author

sadeghbarati commented Feb 7, 2024

Nice changes 鉂わ笍

https://mui.com/material-ui/react-autocomplete/#multiple-values

I would rather

  • open Combobox or Autocomplete with click or enter on input or a trigger just like ComboboxDemo (chevron down)
  • have 100% width dropdown
  • prevent closing dropdown after select

@zernonia
Copy link
Contributor

zernonia commented Feb 7, 2024

Nice changes 鉂わ笍

https://mui.com/material-ui/react-autocomplete/#multiple-values

I would rather

  • open Combobox or Autocomplete with click or enter on input or a trigger just like ComboboxDemo (chevron down)
  • have 100% width dropdown
  • prevent closing dropdown after select

@sadeghbarati All these can be easily done 馃槈 Feel free to modify it!

@zernonia
Copy link
Contributor

zernonia commented Feb 7, 2024

I purposely made ComboboxAnchor anchor to the input because I like that 馃槀. You can move it to the wrap around the component to achieve full width.

Copy link
Contributor

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadeghbarati I've checked the tagsInput and LGTM. You can merge when ready

@sadeghbarati sadeghbarati merged commit 43f9f56 into dev Feb 15, 2024
1 check failed
@sadeghbarati sadeghbarati deleted the feat/tags-input branch February 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants