Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: breadcrumb component #405

Merged
merged 6 commits into from
Mar 13, 2024
Merged

feat: breadcrumb component #405

merged 6 commits into from
Mar 13, 2024

Conversation

Saeid-Za
Copy link
Contributor

@Saeid-Za Saeid-Za commented Mar 12, 2024

resolves #395

@sadeghbarati sadeghbarati changed the title feat: adding breadcrumb component, resolves #395 feat: breadcrumb component Mar 12, 2024
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: 454ecf0d
Status: ✅ Deploy successful!
Preview URL: https://1b8c3009.shadcn-vue.pages.dev
Branch Preview URL: https://1b8c3009.shadcn-vue.pages.dev

build registry, bump radix-vue
Copy link
Collaborator

@sadeghbarati sadeghbarati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sadeghbarati
Copy link
Collaborator

@Saeid-Za Hey

PrimitiveProps already has as type inside of it, so I just updated your code to prevent duplicated interface

Copy link
Contributor

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @Saeid-Za ! 💚

@zernonia zernonia merged commit 4d08adc into radix-vue:dev Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Breadcrumb component
3 participants