Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect Installs, mismatch in component content #74

Closed
orenmizr opened this issue Sep 22, 2023 · 4 comments · Fixed by #129
Closed

[Bug]: Incorrect Installs, mismatch in component content #74

orenmizr opened this issue Sep 22, 2023 · 4 comments · Fixed by #129
Labels
bug Something isn't working

Comments

@orenmizr
Copy link

orenmizr commented Sep 22, 2023

Environment

"radix-vue": "^0.2.3",
    "tailwind-merge": "^1.14.0",
    "tailwindcss-animate": "^1.0.7",
    "class-variance-authority": "^0.7.0",
    "clsx": "^2.0.0",
"@nuxtjs/tailwindcss": "^6.8.0",

linux.

Link to minimal reproduction

https://github.com/radix-vue/

Steps to reproduce

follow docs's install for a button and add it via the cli.

Describe the bug

followed the docs.

  1. when installing a button there is a difference between the copy code from site and the button via the add cli.
  2. when you add the code via cli its adds on my linux extra quotes which makes the component unusable until manually corrected.

"'Button'" instead of "Button"

Expected behavior

  1. valid code. that compiles.
  2. to match the content that is manually. (looking at the classes i saw different sets)

Conext & Screenshots (if applicable)

No response

@orenmizr orenmizr added the bug Something isn't working label Sep 22, 2023
@zernonia
Copy link
Contributor

@orenmizr at which line that it added extra single quote ya? In @/components/button/index.ts?

@orenmizr
Copy link
Author

it was all the files that were added via the cli (linux machine). instead of correcting it, ended up copying from the "copy to clipboard" in the docs. the import were valid but i don't think the button cli version the web version were 100% the same - i saw classes that were different.

i will add it again to a greenfield project and test it. (in that project, i use pugjs plus i had naive-ui install as well)

@orenmizr
Copy link
Author

in a clean project. it worked well. no extra quotes '""' also the button rendered correct. the only thing i might have done differently is choose css variables this time. other than that, can't really explain. you can close this - if i figure out the issue i will open a specific one. (no pugjs in the clean nuxt project also might be related)

@SGDS-SyL
Copy link

Any update on this? Facing the same issue as well

@zernonia zernonia linked a pull request Oct 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants